[all-commits] [llvm/llvm-project] 9d31d1: [ConstraintElimination] Use logic from 3771310eed ...

Florian Hahn via All-commits all-commits at lists.llvm.org
Sat Oct 8 03:05:45 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9d31d1c214e0f010fbb12ecb1780ac27dab6e435
      https://github.com/llvm/llvm-project/commit/9d31d1c214e0f010fbb12ecb1780ac27dab6e435
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2022-10-08 (Sat, 08 Oct 2022)

  Changed paths:
    M llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
    M llvm/test/Transforms/ConstraintElimination/signed-query-unsigned-system.ll

  Log Message:
  -----------
  [ConstraintElimination] Use logic from 3771310eed for queries only.

The logic added in 3771310eed was placed sub-optimally. Applying the
transform in ::getConstraint meant that it would also impact conditions
that are added to the system by the signed <-> unsigned transfer logic.

This meant we failed to add some signed facts to the signed system. To
make sure we still add as many useful facts to the signed/unsigned
systems, move the logic to the point where we query the system.




More information about the All-commits mailing list