[all-commits] [llvm/llvm-project] 317b55: Revert "[lld/mac] Port typo correction for undefin...

Hans via All-commits all-commits at lists.llvm.org
Fri Oct 7 04:40:50 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 317b5582b813c51d1fb6723fd44b227b7f274bc7
      https://github.com/llvm/llvm-project/commit/317b5582b813c51d1fb6723fd44b227b7f274bc7
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2022-10-07 (Fri, 07 Oct 2022)

  Changed paths:
    M lld/MachO/SymbolTable.cpp
    R lld/test/MachO/undef-spell-corrector.s
    R lld/test/MachO/undef-suggest-extern-c.s
    R lld/test/MachO/undef-suggest-extern-c2.s

  Log Message:
  -----------
  Revert "[lld/mac] Port typo correction for undefined symbols from ELF port"

This caused crashes/assert failures for some Chromium developers, see comment
on the code review.

> Ports:
> - core feature: https://reviews.llvm.org/D67039
> - case mismatch: https://reviews.llvm.org/D70506
> - extern "C" suggestions: https://reviews.llvm.org/D69592,
>   https://reviews.llvm.org/D69650
>
> Does not port https://reviews.llvm.org/D71735 since I believe that that doesn't
> apply to lld/Mach-O.
>
> Differential Revision: https://reviews.llvm.org/D135038

This reverts commit 8c45e80298f4e3eb6d9cfbafcb099bc087e4668e.




More information about the All-commits mailing list