[all-commits] [llvm/llvm-project] 69c661: [lldb] Skip check for conflicting filter/synth whe...

[Jorge Gorbe Moya via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 69c661a65ff8c04ce9408a788a77df67481545a1
      https://github.com/llvm/llvm-project/commit/69c661a65ff8c04ce9408a788a77df67481545a1
  Author: Jorge Gorbe Moya <jgorbe at google.com>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    M lldb/source/Commands/CommandObjectType.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-python-synth/TestDataFormatterPythonSynth.py

  Log Message:
  -----------
  [lldb] Skip check for conflicting filter/synth when adding a new regex.

When adding a new synthetic child provider, we check for an existing
conflicting filter in the same category (and vice versa). This is done
by trying to match the new type name against registered formatters.

However, the new type name we're registered can also be a regex
(`type synth add -x`), and in this case the conflict check is just
wrong: it will try to match the new regex as if it was a type name,
against previously registered regexes.

See https://github.com/llvm/llvm-project/issues/57947 for a longer
explanation with concrete examples of incorrect behavior.

Differential Revision: https://reviews.llvm.org/D134570