[all-commits] [llvm/llvm-project] 8d1de7: [lldb/gdb-server] Better reporting of launch errors

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8d1de7b34af46a089eb5433c700419ad9b2923ee
      https://github.com/llvm/llvm-project/commit/8d1de7b34af46a089eb5433c700419ad9b2923ee
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    M lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py

  Log Message:
  -----------
  [lldb/gdb-server] Better reporting of launch errors

Use our "rich error" facility to propagate error reported by the stub to
the user. lldb-server reports rich launch errors as of D133352.

To make this easier to implement, and reduce code duplication, I have
moved the vRun/A/qLaunchSuccess handling into a single
GDBRemoteCommunicationClient function.

Differential Revision: https://reviews.llvm.org/D134754


  Commit: 08c4a6795ac40f14d8a4385d28bc4f266ba895f1
      https://github.com/llvm/llvm-project/commit/08c4a6795ac40f14d8a4385d28bc4f266ba895f1
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    M lldb/source/Target/Process.cpp
    M lldb/source/Target/Target.cpp
    M lldb/test/API/functionalities/gdb_remote_client/TestProcessConnect.py

  Log Message:
  -----------
  [lldb] Move breakpoint hit reset code to Target::CleanupProcess

This ensures it is run regardless of the method we use to initiate the
session (previous version did not handle connects), and it is the same
place that is used for resetting watchpoints.

Differential Revision: https://reviews.llvm.org/D134882


Compare: https://github.com/llvm/llvm-project/compare/561443818a15...08c4a6795ac4