[all-commits] [llvm/llvm-project] f47d5d: [mlir][llvmir] Simpler error handling in ConvertFr...

Tobias Gysi via All-commits all-commits at lists.llvm.org
Thu Oct 6 07:35:07 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f47d5dce61cf2704dc15761cea8da4eaf1a7941a
      https://github.com/llvm/llvm-project/commit/f47d5dce61cf2704dc15761cea8da4eaf1a7941a
  Author: Tobias Gysi <tobias.gysi at nextsilicon.com>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    M mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp

  Log Message:
  -----------
  [mlir][llvmir] Simpler error handling in ConvertFromLLVMIR (nfc).

The revision renames some methods of the Importer and changes
the error handling to be closer the ModuleTranslation. In particular,
processValue -> lookupValue and processType -> convertType
now fail if the translation fails (instead of returning an error),
which simplifies the error handling.

The revision prepares a follow up commit that will import
LLVMIR intrinsics using tablegen.

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D135349




More information about the All-commits mailing list