[all-commits] [llvm/llvm-project] 54cdc0: [mlir:Parser] Always splice parsed operations to t...

River Riddle via All-commits all-commits at lists.llvm.org
Wed Oct 5 13:12:03 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 54cdc03dfadfe35a6a98a5970a5b850868176642
      https://github.com/llvm/llvm-project/commit/54cdc03dfadfe35a6a98a5970a5b850868176642
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-10-05 (Wed, 05 Oct 2022)

  Changed paths:
    M mlir/lib/AsmParser/Parser.cpp
    M mlir/lib/Bytecode/Reader/BytecodeReader.cpp
    M mlir/unittests/Parser/ParserTest.cpp

  Log Message:
  -----------
  [mlir:Parser] Always splice parsed operations to the end of the parsed block

The current splicing behavior dates back to when all blocks had terminators,
so we would "helpfully" splice before the terminator. This doesn't make sense
anymore, and leads to somewhat unexpected results when parsing multiple
pieces of IR into the same block.

Differential Revision: https://reviews.llvm.org/D135096




More information about the All-commits mailing list