[all-commits] [llvm/llvm-project] 2cdd24: [mlir][NFC] Make 'printOp' public in AsmPrinter

Diego Caballero via All-commits all-commits at lists.llvm.org
Wed Oct 5 12:01:56 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2cdd246a39076379b1678782f99872f918fa358c
      https://github.com/llvm/llvm-project/commit/2cdd246a39076379b1678782f99872f918fa358c
  Author: Diego Caballero <diegocaballero at google.com>
  Date:   2022-10-05 (Wed, 05 Oct 2022)

  Changed paths:
    M mlir/include/mlir/IR/OpImplementation.h
    M mlir/lib/IR/AsmPrinter.cpp
    A mlir/test/IR/print-op-custom-or-generic.mlir
    R mlir/test/IR/print-op-generic.mlir

  Log Message:
  -----------
  [mlir][NFC] Make 'printOp' public in AsmPrinter

This patch moves the 'printOp' functionality to the public API of
AsmPrinter and rename it to 'printCustomOrGenericOp'. No 'parseOp'
is needed at this time as existing APIs are able to parse operations
producing results where results are omitted in the textual form
(the LHS of an operation is redundant when it comes to building the
operation itself as it only contains the result names).

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D135006




More information about the All-commits mailing list