[all-commits] [llvm/llvm-project] 118977: [InstCombine] Directly replace instr in foldInteg...

Nikita Popov via All-commits all-commits at lists.llvm.org
Wed Oct 5 04:29:27 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 11897708c0229c92802e747564e7c34b722f045f
      https://github.com/llvm/llvm-project/commit/11897708c0229c92802e747564e7c34b722f045f
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-10-05 (Wed, 05 Oct 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineInternal.h
    M llvm/lib/Transforms/InstCombine/InstCombinePHI.cpp

  Log Message:
  -----------
  [InstCombine] Directly replace instr in  foldIntegerTypedPHI() (NFCI)

Rather than inserting a ptrtoint + inttoptr pair, directly replace
the inttoptr with the new phi node. This ensures that no other
transform can undo it before the pair gets folded away.

This avoids the infinite loop when combined with D134954.

This is NFCI in the sense that it shouldn't make a difference, but
could due to different worklist order.




More information about the All-commits mailing list