[all-commits] [llvm/llvm-project] af947d: [ISel] Fix crash in new FMA DAG combine

Jay Foad via All-commits all-commits at lists.llvm.org
Tue Oct 4 07:19:52 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: af947d9fcbbd71b3001ca100e15236a70c8c87b6
      https://github.com/llvm/llvm-project/commit/af947d9fcbbd71b3001ca100e15236a70c8c87b6
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2022-10-04 (Tue, 04 Oct 2022)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    A llvm/test/CodeGen/AMDGPU/dagcombine-fma-crash.ll

  Log Message:
  -----------
  [ISel] Fix crash in new FMA DAG combine

Fix a crash in the FMA combine added by D132837 and amended by D134810.
In cases where the newly created node could be folded, the combiner
would fail this assertion:

llc: DAGCombiner.cpp:268: void (anonymous namespace)::DAGCombiner::AddToWorklist(llvm::SDNode *): Assertion `N->getOpcode() != ISD::DELETED_NODE && "Deleted Node added to Worklist"' failed.

Differential Revision: https://reviews.llvm.org/D135150




More information about the All-commits mailing list