[all-commits] [llvm/llvm-project] 247c84: [mlir] Reduce call stack depth in LogicalResult. NFC.

[Jakub Kuderski via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 247c84aef6eb8266a9c286f9bbde5f7bb0588cbc
      https://github.com/llvm/llvm-project/commit/247c84aef6eb8266a9c286f9bbde5f7bb0588cbc
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2022-10-03 (Mon, 03 Oct 2022)

  Changed paths:
    M mlir/include/mlir/Support/LogicalResult.h

  Log Message:
  -----------
  [mlir] Reduce call stack depth in LogicalResult. NFC.

When debuging a crash or conversion failure in a deep pass pipeline,
there are often many interleaved frames with `failed` and `succeeded`.
`LogicalResult` is used through the pass infrastructure, so by not implementing
failure in terms of a call to succeess, this patch noticeably reduces the total
total call stack depth and improves the debugging experience.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D135116