[all-commits] [llvm/llvm-project] 5585d9: [NVPTX] Fix issues in ptxas integration to LIT tests

Andrew Savonichev via All-commits all-commits at lists.llvm.org
Mon Oct 3 14:30:57 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5585d99835e83cca79ead9f0d90fcfab927391d5
      https://github.com/llvm/llvm-project/commit/5585d99835e83cca79ead9f0d90fcfab927391d5
  Author: Andrew Savonichev <andrew.savonichev at gmail.com>
  Date:   2022-10-04 (Tue, 04 Oct 2022)

  Changed paths:
    M llvm/test/CodeGen/NVPTX/atomicrmw-expand.ll
    M llvm/test/CodeGen/NVPTX/bug52623.ll
    M llvm/test/CodeGen/NVPTX/ldu-ldg.ll
    M llvm/test/lit.cfg.py
    M llvm/test/lit.site.cfg.py.in

  Log Message:
  -----------
  [NVPTX] Fix issues in ptxas integration to LIT tests

1) Fixed a typo in PTXAS_EXECUTABLE CMake variable (PXTAS -> PTXAS).

2) Version check was implemented incorrectly,
   now version (major, minor) is converted to int for comparison.

3) ptxas -arch argument was incorrect (or missing) in 3 tests.

Differential Revision: https://reviews.llvm.org/D127866


  Commit: d420110a1e9d620632d47366d569d234026b9e0e
      https://github.com/llvm/llvm-project/commit/d420110a1e9d620632d47366d569d234026b9e0e
  Author: Andrew Savonichev <andrew.savonichev at gmail.com>
  Date:   2022-10-04 (Tue, 04 Oct 2022)

  Changed paths:
    M llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
    M llvm/test/CodeGen/NVPTX/addrspacecast-gvar.ll

  Log Message:
  -----------
  [NVPTX] Fix constant expression initializers for global variables

Before this patch the code in printScalarConstant was unable to handle
nested constant expressions like (gep (addrspacecast ptr)) and crashed
with:

LLVM ERROR: Unsupported expression in static initializer:
  addrspacecast ([4 x i8] addrspace(1)* @ga to [4 x i8]*)

We can use lowerConstantForGV instead which is a customized version of
lowerConstant that supports generic() and nested expressions.

Differential Revision: https://reviews.llvm.org/D127878


Compare: https://github.com/llvm/llvm-project/compare/3933c43d9008...d420110a1e9d


More information about the All-commits mailing list