[all-commits] [llvm/llvm-project] f3e87a: [RISCV] Add missing VL arguments to the creation o...

Craig Topper via All-commits all-commits at lists.llvm.org
Mon Oct 3 12:21:23 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f3e87a63e50bac4c7e21fbe229dc5aefae32555c
      https://github.com/llvm/llvm-project/commit/f3e87a63e50bac4c7e21fbe229dc5aefae32555c
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2022-10-03 (Mon, 03 Oct 2022)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
    M llvm/lib/Target/RISCV/RISCVISelLowering.cpp
    M llvm/test/CodeGen/RISCV/rvv/stepvector.ll

  Log Message:
  -----------
  [RISCV] Add missing VL arguments to the creation of RISCVISD::VMV_V_X_VL nodes.

VMV_V_X_VL nodes should always have a passthru, a splat, and a VL.
We were sometimes missing the VL.

This went unnoticed because these cases were all selected into the
following node to form a .vx or .vi instruction. The ComplexPattern
that does this, doesn't check the VL operand. I've added an assert
to the ComplexPattern to catch if the operand is missing.

@qcolombet spotted some of these in D134703.




More information about the All-commits mailing list