[all-commits] [llvm/llvm-project] e8c10f: [llvm-libtool-darwin] Parse and ignore -syslibroot

Keith Smiley via All-commits all-commits at lists.llvm.org
Mon Oct 3 09:54:25 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e8c10fc1811f2cf7e9a2b4921d9a065ee6384588
      https://github.com/llvm/llvm-project/commit/e8c10fc1811f2cf7e9a2b4921d9a065ee6384588
  Author: Keith Smiley <keithbsmiley at gmail.com>
  Date:   2022-10-03 (Mon, 03 Oct 2022)

  Changed paths:
    A llvm/test/tools/llvm-libtool-darwin/ignored-options.test
    M llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp

  Log Message:
  -----------
  [llvm-libtool-darwin] Parse and ignore -syslibroot

cctools libtool allows you to link dynamic libraries by passing through
a number of arguments to ld64. Because of this the default arguments
libtool receives in Xcode contains arguments that only matter in that
case. This change ignores this argument, at least until we ever support
that dynamic use case, so that you can use llvm-libtool-darwin as a
drop-in replacement in Xcode for cctools libtool. There are more
arguments we could ignore for this case, but we can probably add those
as the use case comes up.

Differential Revision: https://reviews.llvm.org/D134309


  Commit: 10f22335f3b7c7b78b54ee6b995f6ed97e4c225d
      https://github.com/llvm/llvm-project/commit/10f22335f3b7c7b78b54ee6b995f6ed97e4c225d
  Author: Keith Smiley <keithbsmiley at gmail.com>
  Date:   2022-10-03 (Mon, 03 Oct 2022)

  Changed paths:
    A llvm/test/tools/llvm-libtool-darwin/Inputs/DependencyDump.py
    A llvm/test/tools/llvm-libtool-darwin/dependency-info.test
    A llvm/tools/llvm-libtool-darwin/DependencyInfo.h
    M llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp

  Log Message:
  -----------
  [llvm-libtool-darwin] Add support for -dependency_info

When using llvm-libtool-darwin as a drop in replacement for cctools
libtool, Xcode expects you to create a dependency info file. This file
is a very simple format describing the input files, the output files,
and the version of the tool. This logic is mirrored from that of
ld64.lld, which supports creating this file as well. Ideally we could
extract it, but I don't think we want to throw this into one of the
grab-bag libraries given how small the logic is.

Differential Revision: https://reviews.llvm.org/D134322


Compare: https://github.com/llvm/llvm-project/compare/21f97fdc9788...10f22335f3b7


More information about the All-commits mailing list