[all-commits] [llvm/llvm-project] 30578c: dependency cycle fix in DynamicLoaderDarwinKernel

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 30578c08568bc8de79dea72e41f49899ba10ea55
      https://github.com/llvm/llvm-project/commit/30578c08568bc8de79dea72e41f49899ba10ea55
  Author: Jason Molenda <jason at molenda.com>
  Date:   2022-09-09 (Fri, 09 Sep 2022)

  Changed paths:
    M lldb/source/Plugins/DynamicLoader/Darwin-Kernel/CMakeLists.txt

  Log Message:
  -----------
  dependency cycle fix in DynamicLoaderDarwinKernel

DynamicLoaderDarwinKernel calls in to PlatformDarwinKernel, and
with my changes in https://reviews.llvm.org/D133534, PlatformDarwinKernel
calls in to DynamicLoaderDarwinKernel.  This results in a cmake
dependency if accurately included in the link libraries list.

lldbPluginDynamicLoaderDarwinKernel is specfically for kernel
debugging and is uncommonly linked in to anything except a full
lldb.  lldbPluginPlatformMacOSX is any Darwin platform, including
PlatformDarwinKernel, and is referenced a number of time in shell
tests, for instance.

I believe anything linking the darwin kernel DynamicLoader plugin
will already have lldbPluginPlatformMacOSX in its dependency list,
so not explicitly expressing this dependency is safe.