[all-commits] [llvm/llvm-project] fb98a6: [mlir] NFC - move declaration of `Range` to Static...

Chris via All-commits all-commits at lists.llvm.org
Thu Sep 8 15:30:13 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fb98a623fb06f2d557a88cbf1fa51377b38c64bd
      https://github.com/llvm/llvm-project/commit/fb98a623fb06f2d557a88cbf1fa51377b38c64bd
  Author: Christopher Bate <cbate at nvidia.com>
  Date:   2022-09-08 (Thu, 08 Sep 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/Utils/StaticValueUtils.h
    M mlir/include/mlir/Interfaces/ViewLikeInterface.h

  Log Message:
  -----------
  [mlir] NFC - move declaration of `Range` to StaticValueUtils.h

`ViewLikeInterface.h` defines a struct `Range`, and it also depends on
`StaticValueUtils.h/cpp`. This change moves the definition of `Range` to
`StaticValueUtils.h`, which should not violate any existing dependency
requirement. This is done to support adding utilities using `Range`
under `Dialect/Utils` without creating a circular dependency on
`ViewLikeInterface`. It is possible that some targets depend on
`ViewLikeInterface` just for the `Range` struct. These can be later
updated to depend on the `MLIRDialectUtils` target.

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D133523




More information about the All-commits mailing list