[all-commits] [llvm/llvm-project] 48203b: Revert D130308 "[clang] extend getCommonSugaredTyp...

Fangrui Song via All-commits all-commits at lists.llvm.org
Thu Sep 8 15:09:55 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 48203b327d8ddf2cb785a1ac30b3cd9fa1e54b44
      https://github.com/llvm/llvm-project/commit/48203b327d8ddf2cb785a1ac30b3cd9fa1e54b44
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-09-08 (Thu, 08 Sep 2022)

  Changed paths:
    M clang/include/clang/AST/ASTContext.h
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/Sema/SemaTemplateDeduction.cpp
    M clang/test/SemaCXX/sugar-common-types.cpp

  Log Message:
  -----------
  Revert D130308 "[clang] extend getCommonSugaredType to merge sugar nodes"

This reverts commit 16e5d6d7f98f1119aab3d10ec4f9e59b5aacd359.
There are multiple complaints on the review.

In addition, it may cause spurious
```
error: invalid operands to binary expression ('SinkPrinter' and 'char[cluster_name_length]')
note: candidate template ignored: substitution failure: variably modified type 'char *' cannot be used as a template argument SinkPrinter operator<<(const SinkPrinter &s, T) {
```
for some C++ code




More information about the All-commits mailing list