[all-commits] [llvm/llvm-project] e09c75: [clangd][ObjC] Improve completions for protocols +...

David Goldman via All-commits all-commits at lists.llvm.org
Thu Sep 8 08:31:13 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e09c75049854fee251e99c4c3c55f3f391f52a10
      https://github.com/llvm/llvm-project/commit/e09c75049854fee251e99c4c3c55f3f391f52a10
  Author: David Goldman <davg at google.com>
  Date:   2022-09-08 (Thu, 08 Sep 2022)

  Changed paths:
    M clang-tools-extra/clangd/CodeComplete.cpp
    M clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
    M clang-tools-extra/clangd/unittests/TestIndex.cpp
    M clang-tools-extra/clangd/unittests/TestIndex.h

  Log Message:
  -----------
  [clangd][ObjC] Improve completions for protocols + category names

- Render protocols as interfaces to differentiate them from classes
  since a protocol and class can have the same name. Take this one step
  further though, and only recommend protocols in ObjC protocol completions.

- Properly call `includeSymbolFromIndex` even with a cached
  speculative fuzzy find request

- Don't use the index to provide completions for category names,
  symbols there don't make sense

Differential Revision: https://reviews.llvm.org/D132962




More information about the All-commits mailing list