[all-commits] [llvm/llvm-project] 326279: [MCA] Correctly check pipeline availability for pa...

Andrea Di Biagio via All-commits all-commits at lists.llvm.org
Wed Sep 7 04:20:06 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3262794804ad23ed4a511669ffc97d128512bc37
      https://github.com/llvm/llvm-project/commit/3262794804ad23ed4a511669ffc97d128512bc37
  Author: Andrea Di Biagio <andrea.dibiagio at sony.com>
  Date:   2022-09-07 (Wed, 07 Sep 2022)

  Changed paths:
    M llvm/include/llvm/MCA/Instruction.h
    M llvm/lib/MCA/HardwareUnits/ResourceManager.cpp
    M llvm/lib/MCA/InstrBuilder.cpp
    A llvm/test/tools/llvm-mca/X86/AlderlakeP/partially-overlapping-groups.s

  Log Message:
  -----------
  [MCA] Correctly check pipeline availability for partially overlapping resource groups.

This patch mostly reverts commit 70b37f4c03c which fixed PR50725.

In case of explicit consumption of multiple partially overlapping group
resources, the ResourceManager was not correctly checking pipeline
esources availability.

The fix for PR50725 only partially addressed a few instances of that issue.
This is a more general (although, technically slower) fix for that same issue.

It also fixes Issue #57548

Thanks to Haohai Wen for the small reproducible.




More information about the All-commits mailing list