[all-commits] [llvm/llvm-project] 6a378b: [mlir][spirv] Add base classes for vendor ops

Jakub Kuderski via All-commits all-commits at lists.llvm.org
Tue Sep 6 10:36:07 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6a378b38ff30a970bf3aa06ae2819679ba2747b0
      https://github.com/llvm/llvm-project/commit/6a378b38ff30a970bf3aa06ae2819679ba2747b0
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td

  Log Message:
  -----------
  [mlir][spirv] Add base classes for vendor ops

This is the first patch in the series to rename vendor ops from
`spv.NameVENDOR` to `spv.VENDOR.Name`. The goal is to make the SPIR-V
dialect more internally consistent.

Issue: https://github.com/llvm/llvm-project/issues/56863


  Commit: b8bea837f34534c36fd07477e51b41dd222fb869
      https://github.com/llvm/llvm-project/commit/b8bea837f34534c36fd07477e51b41dd222fb869
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVAtomicOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVCooperativeMatrixOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVGroupOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVJointMatrixOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVMiscOps.td
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    M mlir/test/lib/Dialect/SPIRV/TestAvailability.cpp
    M mlir/utils/spirv/define_inst.sh
    M mlir/utils/spirv/gen_spirv_dialect.py

  Log Message:
  -----------
  [mlir][spirv] Refactor vendor op definitions

Use dedicated vendor op classes/categories. This is so that we can later
change the mnemonics of all vendor ops by changing the base class: `SPV_VendorOp`.

Issue: https://github.com/llvm/llvm-project/issues/56863


  Commit: 817de304d541d02047e4684f77bf46956d009f04
      https://github.com/llvm/llvm-project/commit/817de304d541d02047e4684f77bf46956d009f04
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVAtomicOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVCooperativeMatrixOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVGroupOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVJointMatrixOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVMiscOps.td
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    M mlir/test/Dialect/SPIRV/IR/atomic-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/cooperative-matrix-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/group-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/joint-matrix-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/misc-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/target-env.mlir
    M mlir/test/Dialect/SPIRV/Transforms/vce-deduction.mlir
    M mlir/test/Target/SPIRV/atomic-ops.mlir
    M mlir/test/Target/SPIRV/cooperative-matrix-ops.mlir
    M mlir/test/Target/SPIRV/group-ops.mlir
    M mlir/test/Target/SPIRV/joint-matrix-ops.mlir
    M mlir/test/lib/Dialect/SPIRV/TestAvailability.cpp

  Log Message:
  -----------
  [mlir][spirv] Change vendor op mnemonics to `spv.VENDOR.name`

Make vendor ops more consistent with the naming scheme within the SPIR-V
dialect.

Issue: https://github.com/llvm/llvm-project/issues/56863

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D133247


Compare: https://github.com/llvm/llvm-project/compare/94c6dfbaebbd...817de304d541


More information about the All-commits mailing list