[all-commits] [llvm/llvm-project] 0b1aee: Revert "[mlir][Tensor] Add rewrites to extract sli...

Mehdi Amini via All-commits all-commits at lists.llvm.org
Fri Sep 2 16:37:01 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0b1aee38bd2ffbf9f4f70e95c7cb18031d282544
      https://github.com/llvm/llvm-project/commit/0b1aee38bd2ffbf9f4f70e95c7cb18031d282544
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2022-09-02 (Fri, 02 Sep 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/Tensor/IR/TensorOps.td
    R mlir/include/mlir/Dialect/Tensor/Transforms/TransformUtils.h
    M mlir/include/mlir/Dialect/Utils/ReshapeOpsUtils.h
    M mlir/include/mlir/Interfaces/ViewLikeInterface.h
    M mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
    M mlir/lib/Dialect/Tensor/Transforms/CMakeLists.txt
    R mlir/lib/Dialect/Tensor/Transforms/ExtractSliceFromReshape.cpp
    M mlir/lib/Dialect/Utils/CMakeLists.txt
    M mlir/lib/Dialect/Utils/ReshapeOpsUtils.cpp
    M mlir/lib/Interfaces/ViewLikeInterface.cpp
    R mlir/test/Dialect/Tensor/extract-slice-from-collapse-shape.mlir
    M mlir/test/lib/Dialect/Tensor/CMakeLists.txt
    M mlir/test/lib/Dialect/Tensor/TestTensorTransforms.cpp

  Log Message:
  -----------
  Revert "[mlir][Tensor] Add rewrites to extract slices through `tensor.collape_shape`"

This reverts commit 5711957875738c1318f89afd7bf4be388f85a087.

A circular dependency is introduced here from Dialect/Utils/ to the
ViewLikeInterface, but it already depends on Dialect/Utils.

Also this introduces a dependency from lib/Dialect/Tensor to Linalg,
which isn't obviously correct from a layering point of view.




More information about the All-commits mailing list