[all-commits] [llvm/llvm-project] f021cb: [NFC] Remove duplicate code in SBTypeCategory

Jorge Gorbe Moya via All-commits all-commits at lists.llvm.org
Fri Sep 2 16:05:48 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f021cb57ce786f7d5a6c921a19bbcf56709b6ce0
      https://github.com/llvm/llvm-project/commit/f021cb57ce786f7d5a6c921a19bbcf56709b6ce0
  Author: Jorge Gorbe Moya <jgorbe at google.com>
  Date:   2022-09-02 (Fri, 02 Sep 2022)

  Changed paths:
    M lldb/source/API/SBTypeCategory.cpp

  Log Message:
  -----------
  [NFC] Remove duplicate code in SBTypeCategory

TypeCategoryImpl has its own implementation of these, so it makes no
sense to have the same logic inlined in SBTypeCategory.

There are other methods in SBTypeCategory that are directly implemented
there, instead of delegating to TypeCategoryImpl (which IMO kinda
defeats the point of having an "opaque" member pointer in the SB type),
but they don't have equivalent implementations in TypeCategoryImpl, so
this patch only picks the low-hanging fruit for now.




More information about the All-commits mailing list