[all-commits] [llvm/llvm-project] 1a4d85: [MinGW] Ignore -fvisibility/-fvisibility-inlines-h...

Fangrui Song via All-commits all-commits at lists.llvm.org
Fri Sep 2 09:59:32 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1a4d851d272d141fb39ff9a0b2572dfa4411c5c5
      https://github.com/llvm/llvm-project/commit/1a4d851d272d141fb39ff9a0b2572dfa4411c5c5
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-09-02 (Fri, 02 Sep 2022)

  Changed paths:
    M clang/lib/CodeGen/CodeGenModule.cpp
    A clang/test/CodeGenCXX/dllstorage-visibility.cpp
    R clang/test/CodeGenCXX/hidden-dllimport.cpp

  Log Message:
  -----------
  [MinGW] Ignore -fvisibility/-fvisibility-inlines-hidden for dllexport

Similar to 123ce97fac78bc4519afd5d2aba17c59c5717aad for dllimport: dllexport
expresses a non-hidden visibility intention. We can consider it explicit and
therefore it should override the global visibility setting (see AST/Decl.cpp
"NamedDecl Implementation").

Adding the special case to CodeGenModule::setGlobalVisibility is somewhat weird,
but allows we to add the code in one place instead of many in AST/Decl.cpp.

Differential Revision: https://reviews.llvm.org/D133180




More information about the All-commits mailing list