[all-commits] [llvm/llvm-project] 7338f9: [TTI] Improve description of TargetCostKind enums ...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Fri Sep 2 03:09:28 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7338f9709bba25d23960dfea475efa2e49608c1c
      https://github.com/llvm/llvm-project/commit/7338f9709bba25d23960dfea475efa2e49608c1c
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-09-02 (Fri, 02 Sep 2022)

  Changed paths:
    M llvm/include/llvm/Analysis/TargetTransformInfo.h

  Log Message:
  -----------
  [TTI] Improve description of TargetCostKind enums to aid targets in choosing cost values

I'm not sure how much to add to the description as we've tried to allow targets to interpret the TargetCostKind enums in their own way. But we need to make it clear that certain cost kinds need to match threshold numbers used by various passes (and vice-versa when passes are determining a cost-benefit threshold).

I'm not keen on the "The weighted sum of size and latency" description, but its very difficult to come up with anything else that's suitably generic (e.g. X86 will use uop counts here to easily work with LoopMicroOpBufferSize thresholds, even though high latency fdiv/fsqrt instructions still often have low uop counts).

Differential Revision: https://reviews.llvm.org/D132288




More information about the All-commits mailing list