[all-commits] [llvm/llvm-project] 0cb080: [Clang][Comments] Parse `<img src=""/>` in doc com...

Egor Zhdan via All-commits all-commits at lists.llvm.org
Thu Sep 1 05:18:00 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0cb08093365478224f2a58cece42527fb8e1199e
      https://github.com/llvm/llvm-project/commit/0cb08093365478224f2a58cece42527fb8e1199e
  Author: Egor Zhdan <e_zhdan at apple.com>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M clang/lib/AST/CommentLexer.cpp
    M clang/test/Index/comment-to-html-xml-conversion.cpp
    M clang/test/Sema/warn-documentation.cpp

  Log Message:
  -----------
  [Clang][Comments] Parse `<img src=""/>` in doc comments correctly

This is a valid HTML5 tag. Previously it triggered a Clang error (`HTML start tag prematurely ended, expected attribute name or '>'`) since Clang was treating `/>` as a text token. This was happening because after lexing the closing quote (`"`) the lexer state was reset to "Normal" while the tag was not actually closed yet: `>` was not yet parsed at that point.

rdar://91464292

Differential Revision: https://reviews.llvm.org/D132932




More information about the All-commits mailing list