[all-commits] [llvm/llvm-project] 5ad6ed: Change the meaning of a UUID with all zeros for data.

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5ad6ed0e5519ed26442cd0a21cdb07f5c53b854e
      https://github.com/llvm/llvm-project/commit/5ad6ed0e5519ed26442cd0a21cdb07f5c53b854e
  Author: Jim Ingham <jingham at apple.com>
  Date:   2022-08-30 (Tue, 30 Aug 2022)

  Changed paths:
    M lldb/include/lldb/Utility/UUID.h
    M lldb/source/API/SBModuleSpec.cpp
    M lldb/source/Core/DataFileCache.cpp
    M lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm
    M lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
    M lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
    M lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
    M lldb/source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp
    M lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
    M lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
    M lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp
    M lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
    M lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
    M lldb/source/Utility/UUID.cpp
    M lldb/unittests/ObjectFile/Breakpad/BreakpadRecordsTest.cpp
    M lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
    M lldb/unittests/SymbolFile/DWARF/DWARFIndexCachingTest.cpp
    M lldb/unittests/Utility/UUIDTest.cpp

  Log Message:
  -----------
  Change the meaning of a UUID with all zeros for data.

Previously, depending on how you constructed a UUID from data or a
StringRef, an input value of all zeros was valid (e.g. setFromData)
or not (e.g. setFromOptionalData).  Since there was no way to tell
which interpretation to use, it was done somewhat inconsistently.
This standardizes the meaning of a UUID of all zeros to Not Valid,
and removes all the Optional methods and their uses, as well as the
static factories that supported them.

Differential Revision: https://reviews.llvm.org/D132191