[all-commits] [llvm/llvm-project] 8e29e3: [libcxx] [test] Remove an unnecessary condition in...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8e29e379b03541ae8dcfb9e797bfc3305f2a8756
      https://github.com/llvm/llvm-project/commit/8e29e379b03541ae8dcfb9e797bfc3305f2a8756
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-08-30 (Tue, 30 Aug 2022)

  Changed paths:
    M libcxx/utils/libcxx/test/features.py

  Log Message:
  -----------
  [libcxx] [test] Remove an unnecessary condition in a feature check

We don't need to check for `_LIBCPP_HAS_NO_LOCALIZATION` here;
this was copied over by mistake from the test above (which does
use locale.h).

Differential Revision: https://reviews.llvm.org/D132834


  Commit: 118038e878cf7c169c74cdf31de019913775e881
      https://github.com/llvm/llvm-project/commit/118038e878cf7c169c74cdf31de019913775e881
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-08-30 (Tue, 30 Aug 2022)

  Changed paths:
    M lldb/source/Host/common/TCPSocket.cpp

  Log Message:
  -----------
  [lldb] Use the NativeSock type instead of plain 'int'

This fixes a warning when building for Windows:

    ../tools/lldb/source/Host/common/TCPSocket.cpp:297:16: warning: comparison of integers of different signs: 'int' and 'const NativeSocket' (aka 'const unsigned long long') [-Wsign-compare]
          if (sock != kInvalidSocketValue) {
              ~~~~ ^  ~~~~~~~~~~~~~~~~~~~

Differential Revision: https://reviews.llvm.org/D132841


Compare: https://github.com/llvm/llvm-project/compare/f908cbc36fc9...118038e878cf