[all-commits] [llvm/llvm-project] b345be: Make this test slightly less fragile; NFC

Aaron Ballman via All-commits all-commits at lists.llvm.org
Mon Aug 29 06:41:42 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b345be177d03166add391f090fd0288a23413934
      https://github.com/llvm/llvm-project/commit/b345be177d03166add391f090fd0288a23413934
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2022-08-29 (Mon, 29 Aug 2022)

  Changed paths:
    M clang/test/Frontend/sarif-diagnostics.cpp

  Log Message:
  -----------
  Make this test slightly less fragile; NFC

The rule IDs are not stable, so this uses a regex for the rule ids
instead of concrete values. It also moves the CHECK lines below the
code so that it's easier to modify the test in the future. It also
breaks the CHECK lines into multiple lines to improve the performance
of the test and aid in debugging failures. Finally, it adds a comment
to the top of the test explaining that things are still rather fragile.




More information about the All-commits mailing list