[all-commits] [llvm/llvm-project] 9e1a4c: [clang-tidy] Fix for bugprone-sizeof-expression PR...

Chris Hamilton via All-commits all-commits at lists.llvm.org
Fri Aug 19 14:30:11 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9e1a4ce0b55db1388351550497e5ce43b588f71c
      https://github.com/llvm/llvm-project/commit/9e1a4ce0b55db1388351550497e5ce43b588f71c
  Author: eahcmrh <chris.hamilton at ericsson.com>
  Date:   2022-08-19 (Fri, 19 Aug 2022)

  Changed paths:
    M clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp
    A clang-tools-extra/test/clang-tidy/checkers/bugprone/sizeof-expression-2.c
    M clang-tools-extra/test/clang-tidy/checkers/bugprone/sizeof-expression.cpp

  Log Message:
  -----------
  [clang-tidy] Fix for bugprone-sizeof-expression PR57167

This addresses a change in behavior of the bugprone-sizeof-expression
checker after upstream commit 15f3cd6bfc6, which cleaned up
ElaboratedType sugaring in the AST.  This restores (mostly) the
beahvior of the checker prior to that commit, which may or may not have
been consistent with the intent of the checker, but at least gave a
tolerable level of what users would consider false positives.

Bug: https://github.com/llvm/llvm-project/issues/57167

Reviewed By: mizvekov, aaron.ballman

Differential Revision: https://reviews.llvm.org/D131926

Change-Id: Ibe5aad77ad00977134aa7fa67efbbd6bd725fd79




More information about the All-commits mailing list