[all-commits] [llvm/llvm-project] 73a9df: MC: make section classification a bit more thorough

Saleem Abdulrasool via All-commits all-commits at lists.llvm.org
Fri Aug 19 09:47:01 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 73a9dfcee24df959b59a46d75dcbdc0bcfb50fe6
      https://github.com/llvm/llvm-project/commit/73a9dfcee24df959b59a46d75dcbdc0bcfb50fe6
  Author: Saleem Abdulrasool <compnerd at compnerd.org>
  Date:   2022-08-19 (Fri, 19 Aug 2022)

  Changed paths:
    M llvm/lib/MC/MCContext.cpp

  Log Message:
  -----------
  MC: make section classification a bit more thorough

This does *NOT* change the emitted section flags in any way.  This only
impacts the internal classification of sections.

Extend the section classification in LLVM for ELF targets.  This has one
important change: we now classify sections as text by default rather
than readonly.  This matches the behaviour for GAS better.

Ensure that any section that has a writable attribute set is not treated
as readonly.  We also special case any section named `.debug_` which is
reserved for DWARF as metadata.  In the case none of the attributes are
set (or because no attributes were provided), consult the section name
for classification.  We match the well known names and classify the
section accordingly.  Any remaining section is now classified as text.

This change allows us to classify sections in the MC layer more
precisely which is needed for subsequent changes for handling target
specific behaviour.

Differential Revision: https://reviews.llvm.org/D131270
Reviewed By: @echristo




More information about the All-commits mailing list