[all-commits] [llvm/llvm-project] d6e1e0: [lldb] [Core] Harmonize Communication::Read() retu...

[Michał Górny via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d6e1e01da949c8cb4b869cee1953cf19a6d072c0
      https://github.com/llvm/llvm-project/commit/d6e1e01da949c8cb4b869cee1953cf19a6d072c0
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2022-08-19 (Fri, 19 Aug 2022)

  Changed paths:
    M lldb/source/Core/Communication.cpp
    M lldb/unittests/Core/CommunicationTest.cpp

  Log Message:
  -----------
  [lldb] [Core] Harmonize Communication::Read() returns w/ thread

Harmonize the status and error values of Communication::Read() when
running with and without read thread.  Prior to this change, Read()
would return eConnectionStatusSuccess if read thread was enabled
and the read timed out or reached end-of-file, rather than
the respective states that are returned if read thread was disabled.
Now, it correctly returns eConnectionStatusTimedOut
and eConnectionStatusEndOfFile, and sets the error respectively.

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.llvm.org/D132217