[all-commits] [llvm/llvm-project] 495b8e: [Flang][OpenMP] Provide an error when the minus op...

kiranchandramohan via All-commits all-commits at lists.llvm.org
Thu Aug 18 07:43:32 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 495b8e104d71e984128101b8286531ba6592c35b
      https://github.com/llvm/llvm-project/commit/495b8e104d71e984128101b8286531ba6592c35b
  Author: Kiran Chandramohan <kiran.chandramohan at arm.com>
  Date:   2022-08-18 (Thu, 18 Aug 2022)

  Changed paths:
    M flang/lib/Semantics/check-omp-structure.cpp
    R flang/test/Lower/OpenMP/Todo/reduction-subtract.f90
    M flang/test/Semantics/OpenMP/omp-firstprivate01.f90
    A flang/test/Semantics/OpenMP/omp-reduction-subtract.f90
    M flang/test/Semantics/OpenMP/omp-reduction02.f90
    M flang/test/Semantics/OpenMP/omp-reduction04.f90
    M flang/test/Semantics/OpenMP/omp-reduction07.f90
    M flang/test/Semantics/OpenMP/omp-reduction09.f90

  Log Message:
  -----------
  [Flang][OpenMP] Provide an error when the minus operator is used in a reduction

OpenMP 5.2 standard has deprecated the usage of the minus operation in
reductions. The minus operation also is an unpleasant feature with
varied interpretations.

The patch also changes the usage of the minus operator in some existing testcases.

Discussed in https://discourse.llvm.org/t/openmp-runtime-problem-with-subtraction-reduction/64404

Reviewed By: peixin

Differential Revision: https://reviews.llvm.org/D132060




More information about the All-commits mailing list