[all-commits] [llvm/llvm-project] 531dd3: [LV] Restructure isPredicatedInst and isScalarWith...
Philip Reames via All-commits
all-commits at lists.llvm.org
Thu Aug 18 07:14:28 PDT 2022
Author: Philip Reames <preames at rivosinc.com>
Date: 2022-08-18 (Thu, 18 Aug 2022)
[LV] Restructure isPredicatedInst and isScalarWithPredication (w/a fix for uniform mem ops)
This change reorganizes the code and comments to make the expected semantics of these routines more clear. However, this is *not* an NFC change. The functional change is having isScalarWithPredication return false if the instruction does not need predicated. Specifically, for the case of a uniform memory operation we were previously considering it *not* to be a predicated instruction, but *were* considering it to be scalable with predication.
As can be seen with the test changes, this causes uniform memory ops which should have been lowered as uniform-per-parts values to instead be lowering via naive scalarization or if scalarization is infeasible (i.e. scalable vectors) aborted entirely. I also don't trust the code to bail out correctly 100% of the time, so it's possible we had a crash or miscompile from trying to scalarize something which isn't scalaralizable. I haven't found a concrete example here, but I am suspicious.
Differential Revision: https://reviews.llvm.org/D131093
More information about the All-commits