[all-commits] [llvm/llvm-project] 2bf87a: [ORC][MachO] Fix MachOPlatform after 9189a26664b.
lhames via All-commits
all-commits at lists.llvm.org
Wed Aug 17 18:27:10 PDT 2022
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 2bf87a4946b2dd0b94bfaa01f306a779066f30e7
https://github.com/llvm/llvm-project/commit/2bf87a4946b2dd0b94bfaa01f306a779066f30e7
Author: Lang Hames <lhames at gmail.com>
Date: 2022-08-17 (Wed, 17 Aug 2022)
Changed paths:
M llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
Log Message:
-----------
[ORC][MachO] Fix MachOPlatform after 9189a26664b.
Commit 9189a26664b caused llvm-jitlink to create bare JITDylibs to wrap real
dylibs loaded via -preload. This exposed a bug in MachOPlatform where we
assumed that all JITDylibs had been registered with the platform through
MachOPlatform::setupJITDylib (bare JITDylibs are _not_ run through this
function), and errored out where this was not the case.
This bug in MachOPlatform was causing test failures in compilert-rt:
Failed Tests (2):
ORC-x86_64-darwin :: TestCases/Darwin/x86-64/trivial-objc-methods.S
ORC-x86_64-darwin :: TestCases/Darwin/x86-64/trivial-swift-types-section.S
This commit fixes the issue by skipping JITDylibs that haven't been registered
with the platform via MachOPlatform::setupJITDylib.
More information about the All-commits
mailing list