[all-commits] [llvm/llvm-project] 8fe069: [mlir] Update when to check for non-null optional ...

Jacques Pienaar via All-commits all-commits at lists.llvm.org
Wed Aug 17 17:01:02 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8fe06911611a70373a54f12023dd8c66147d2612
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2022-08-17 (Wed, 17 Aug 2022)

  Changed paths:
    M mlir/include/mlir/IR/OpBase.td
    M mlir/test/mlir-tblgen/op-attribute.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  [mlir] Update when to check for non-null optional default attr

OptionalAttr does the wrapping with Optional explicitly in ODS while
default valued optional attribute doesn't (and follows DefaultValuedAttr
in this behavior/meant as drop-in for updating old behavior), update
when to emit check for non-null to account for this.  Also add variant
for optional default valued string attribute to have same convenience as
default valued string attribute.

More information about the All-commits mailing list