[all-commits] [llvm/llvm-project] ee986a: [mlir][sparse] Refactoring: remove Operation * fro...

PeimingLiu via All-commits all-commits at lists.llvm.org
Tue Aug 16 14:26:57 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ee986ab72711d838a7e7ff363c0d2efa7dba91e8
  Author: Peiming Liu <peiming at google.com>
  Date:   2022-08-16 (Tue, 16 Aug 2022)

  Changed paths:
    M mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp

  Log Message:
  [mlir][sparse] Refactoring: remove Operation * from the argument list in utility functions

This patch remove the Operation *op from the argument list in utility functions, and directly pass the Location instead of calling op->getLoc().

This should make the code more clear, as the utility function (logically) does not relies on the operation that we are currently rewriting, and they behave the same regardless of the operation.

Reviewed By: aartbik, wrengr

Differential Revision: https://reviews.llvm.org/D131991

More information about the All-commits mailing list