[all-commits] [llvm/llvm-project] 65d83b: [clang][Darwin] Re-apply "Always set the default C...

Louis Dionne via All-commits all-commits at lists.llvm.org
Tue Aug 16 06:28:53 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 65d83ba34378b8e740c5203fe46a9c50d2aeb862
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2022-08-16 (Tue, 16 Aug 2022)

  Changed paths:
    M clang/lib/Driver/ToolChains/Darwin.cpp
    M clang/test/Driver/Xarch.c
    M clang/test/Driver/apple-kext-mkernel.c
    M clang/test/Driver/arc.c
    M clang/test/Driver/bindings.c
    M clang/test/Driver/cc-log-diagnostics.c
    M clang/test/Driver/cpp-precomp.c
    M clang/test/Driver/darwin-debug-flags.c
    M clang/test/Driver/darwin-dsymutil.c
    M clang/test/Driver/darwin-iphone-defaults.m
    M clang/test/Driver/darwin-stdlib.cpp
    M clang/test/Driver/darwin-verify-debug.c
    M clang/test/Driver/diagnostics.c
    M clang/test/Driver/exceptions.m
    M clang/test/Driver/redundant-args.c
    M clang/test/Headers/float-darwin.c
    M clang/test/Headers/tgmath-darwin.c
    M clang/test/PCH/reloc.c
    M clang/test/lit.cfg.py

  Log Message:
  [clang][Darwin] Re-apply "Always set the default C++ Standard Library to libc++"

Newer SDKs don't even provide libstdc++ headers, so it's effectively
never valid to build for libstdc++ unless the user explicitly asks
for it (in which case they will need to provide include paths and more).

This is a re-application of c5ccb78ade81 which had been reverted in
33171df9cc7f because it broke the Fuchsia CI bots. The issue was that
the test was XPASSing because it didn't fail anymore when the
CLANG_DEFAULT_CXX_LIB was set to libc++, which seems to be done for
Fuchsia. Instead, the test only fails if CLANG_DEFAULT_CXX_LIB is
set to libstdc++.

As a fly-by fix, also adjust the triple used by various tests to
something that is supported. Those tests were shown to fail on
internal bots.

Differential Revision: https://reviews.llvm.org/D131274

More information about the All-commits mailing list