[all-commits] [llvm/llvm-project] f55a6f: [mlir] Make sure that aggregate shared libraries d...

Stella Laurenzo via All-commits all-commits at lists.llvm.org
Mon Aug 15 12:02:46 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f55a6fde1d479144f3448f04438b12178cb59e5f
      https://github.com/llvm/llvm-project/commit/f55a6fde1d479144f3448f04438b12178cb59e5f
  Author: Stella Laurenzo <stellaraccident at gmail.com>
  Date:   2022-08-15 (Mon, 15 Aug 2022)

  Changed paths:
    M mlir/cmake/modules/AddMLIR.cmake

  Log Message:
  -----------
  [mlir] Make sure that aggregate shared libraries define all of their symbols.

We were hitting issues on Linux where this was only being caught at runtime, and different linkers (BFD vs LLD) are differently strict in such situations. Such libraries will also fail to build properly on Windows (but test coverage of that is limited, so it is better to enforce globally).

Differential Revision: https://reviews.llvm.org/D131911




More information about the All-commits mailing list