[all-commits] [llvm/llvm-project] 4d7f9b: X86: Don't fold TEST into ADD ... at GOTTPOFF/GOTNTPO...
James Y Knight via All-commits
all-commits at lists.llvm.org
Fri Aug 12 14:01:56 PDT 2022
Author: James Y Knight <jyknight at google.com>
Date: 2022-08-12 (Fri, 12 Aug 2022)
X86: Don't fold TEST into ADD ... at GOTTPOFF/GOTNTPOFF/INDNTPOFF
The linker may convert such an ADD into a LEA, so we must not
use the EFLAGS output.
This causes miscompiles with -fsanitize=null after
llvm.threadlocal.address -- previously, global variables were known to
be non-null, but the intrinsic is not currently known to return
nonnull. (That should be corrected, but it shouldn't've caused
Differential Revision: https://reviews.llvm.org/D131716
More information about the All-commits