[all-commits] [llvm/llvm-project] 14913f: [LLDB][ARM] Extend testing for vpush emulation

David Spickett via All-commits all-commits at lists.llvm.org
Thu Aug 11 03:02:51 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 14913fa5d0508c3e29ae69552ef0710c82913a75
      https://github.com/llvm/llvm-project/commit/14913fa5d0508c3e29ae69552ef0710c82913a75
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-08-11 (Thu, 11 Aug 2022)

  Changed paths:
    A lldb/test/API/arm/emulation/new-test-files/test-vpush-1-high-sregs-thumb.dat
    M lldb/test/API/arm/emulation/new-test-files/test-vpush-1-thumb.dat

  Log Message:
  -----------
  [LLDB][ARM] Extend testing for vpush emulation

https://reviews.llvm.org/D131658 found a bug in
ReadPseudoRegisterValue which would mean we read out
of bounds if the s register number was high enough.

This adds a memory check to vpush-1-thumb, which
should have been doing that anyway. Then copies that
test and uses the last 4 s registers instead.

Without the mentioned fix we see random values in
the final memory, with the fix it passes.

Reviewed By: fixathon

Differential Revision: https://reviews.llvm.org/D131663




More information about the All-commits mailing list