[all-commits] [llvm/llvm-project] 70074c: [libc++] Fixes string_view comparison operators.

mordante via All-commits all-commits at lists.llvm.org
Wed Aug 10 10:39:03 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 70074cf3972bc3b3828ee21880aa45fb0b8a56e0
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2022-08-10 (Wed, 10 Aug 2022)

  Changed paths:
    M libcxx/include/string_view
    A libcxx/test/std/strings/string.view/string.view.comparison/common_type_specialization.pass.cpp

  Log Message:
  [libc++] Fixes string_view comparison operators.

While implementing `operator<=>` for `string_view` (D130295) @philnik
pointed out `common_type` should be `type_identity`. Since it was an
existing issue that wasn't addressed.

This addresses the issue for both the new and existing equality and
comparison operators. The test is based on the example posted in

Reviewed By: philnik, #libc, huixie90

Differential Revision: https://reviews.llvm.org/D131322

More information about the All-commits mailing list