[all-commits] [llvm/llvm-project] a29fff: [mlir][spirv] Migrate to use specalized enum attri...

Lei Zhang via All-commits all-commits at lists.llvm.org
Tue Aug 9 11:15:21 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a29fffc4752a10494a74bb9f8db9b885c8aa5af1
      https://github.com/llvm/llvm-project/commit/a29fffc4752a10494a74bb9f8db9b885c8aa5af1
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2022-08-09 (Tue, 09 Aug 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVAvailability.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBarrierOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
    M mlir/include/mlir/TableGen/Attribute.h
    M mlir/lib/Conversion/MemRefToSPIRV/MapMemRefStorageClassPass.cpp
    M mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    M mlir/lib/TableGen/Attribute.cpp
    M mlir/lib/Target/SPIRV/Deserialization/DeserializeOps.cpp
    M mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
    M mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
    M mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
    M mlir/test/Conversion/GPUToSPIRV/simple.mlir
    M mlir/test/Conversion/LinalgToSPIRV/linalg-to-spirv.mlir
    M mlir/test/Conversion/MemRefToSPIRV/map-storage-class.mlir
    M mlir/test/Dialect/SPIRV/IR/atomic-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/availability.mlir
    M mlir/test/Dialect/SPIRV/IR/barrier-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/group-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/memory-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/non-uniform-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/structure-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/target-and-abi.mlir
    M mlir/test/Dialect/SPIRV/IR/target-env.mlir
    M mlir/test/Dialect/SPIRV/Transforms/vce-deduction.mlir
    M mlir/test/Target/SPIRV/barrier-ops.mlir
    M mlir/test/Target/SPIRV/group-ops.mlir
    M mlir/test/Target/SPIRV/non-uniform-ops.mlir
    M mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp
    M mlir/unittests/Dialect/SPIRV/SerializationTest.cpp
    M mlir/utils/spirv/gen_spirv_dialect.py

  Log Message:
  -----------
  [mlir][spirv] Migrate to use specalized enum attributes

Previously we are using IntegerAttr to back all SPIR-V enum
attributes. Therefore we all such attributes are showed like
IntegerAttr in IRs, which is barely readable and breaks
roundtripability of the IR. This commit changes to use
`EnumAttr` as the base directly so that we can have separate
attribute definitions and better IR printing.

Reviewed By: kuhar

Differential Revision: https://reviews.llvm.org/D131311




More information about the All-commits mailing list