[all-commits] [llvm/llvm-project] bd3976: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bd3976fed470343be8df9caf0e35d290455b700c
      https://github.com/llvm/llvm-project/commit/bd3976fed470343be8df9caf0e35d290455b700c
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2022-08-08 (Mon, 08 Aug 2022)

  Changed paths:
    M lldb/source/Symbol/LocateSymbolFileMacOSX.cpp

  Log Message:
  -----------
  [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

 - Reduce indentation
 - Extract caching of the DbgShellCommand and the dsymForUUID executable
   (or equivalent)
 - Check the DBGShellCommands before falling back to
   /usr/local/bin/dsymForUUID
 - Don't check ~rc/bin/dsymForUUID
 - Improve error reporting
 - Don't cache the value of LLDB_APPLE_DSYMFORUUID_EXECUTABLE

Differential revision: https://reviews.llvm.org/D131303