[all-commits] [llvm/llvm-project] 41c41f: Revert "[JITLink] Fix some C++17 related fixmes."

lhames via All-commits all-commits at lists.llvm.org
Sun Aug 7 12:16:13 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 41c41fcbc036d75e6b6ea0756857099befbb3313
  Author: Lang Hames <lhames at gmail.com>
  Date:   2022-08-07 (Sun, 07 Aug 2022)

  Changed paths:
    M llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp

  Log Message:
  Revert "[JITLink] Fix some C++17 related fixmes."

This reverts commit 6ea5bf436a983ea9e16a5fe7534c87beca0a61b7.

6ea5bf436a983ea9e16a5fe7534c87beca0a61b7 made use of new c++17 rules regarding
order of evaluation (specifically: in function calls the expression naming the
function should be sequenced before the evalution of any operands) to simplify
some continuation-passing calls. Unfortunately this appears to break at least
one MSVC bot: https://lab.llvm.org/buildbot/#/builders/123/builds/12149 .

Includes an update to the comments to note that the workaround is now based on
MSVC limitations, not on LLVM adopting c++17.

More information about the All-commits mailing list