[all-commits] [llvm/llvm-project] 1c5a50: [mlir][tblgen] Refact mlir-tblgen main into its ow...

zero9178 via All-commits all-commits at lists.llvm.org
Sat Aug 6 05:07:50 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1c5a50e32815a49a41d79ff529ca8611ee49c5c8
      https://github.com/llvm/llvm-project/commit/1c5a50e32815a49a41d79ff529ca8611ee49c5c8
  Author: Markus Böck <markus.boeck02 at gmail.com>
  Date:   2022-08-06 (Sat, 06 Aug 2022)

  Changed paths:
    A mlir/include/mlir/Tools/mlir-tblgen/MlirTblgenMain.h
    M mlir/lib/TableGen/CMakeLists.txt
    A mlir/lib/TableGen/GenInfo.cpp
    M mlir/lib/Tools/CMakeLists.txt
    A mlir/lib/Tools/mlir-tblgen/CMakeLists.txt
    A mlir/lib/Tools/mlir-tblgen/MlirTblgenMain.cpp
    M mlir/tools/mlir-tblgen/CMakeLists.txt
    M mlir/tools/mlir-tblgen/mlir-tblgen.cpp

  Log Message:
  -----------
  [mlir][tblgen] Refact mlir-tblgen main into its own library

This has previously been done for `mlir-opt` and `mlir-reduce` and roughly the same approach has been done here.

The use case for having a separate library is that it is easier for downstream to make custom TableGen backends/executable that work on top of the utilities that are defined in `mlir/TableGen`.
The customization point here is the same one as for any upstream TableGen backends: One can add a new generator by simply creating a global instance of `mlir::GenRegistration`.

Differential Revision: https://reviews.llvm.org/D131112


  Commit: f7b73b7e8e6799d566abeb9954a0617e648b833e
      https://github.com/llvm/llvm-project/commit/f7b73b7e8e6799d566abeb9954a0617e648b833e
  Author: Markus Böck <markus.boeck02 at gmail.com>
  Date:   2022-08-06 (Sat, 06 Aug 2022)

  Changed paths:
    M llvm/include/llvm/Transforms/IPO/SampleContextTracker.h
    M llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCInstrInfo.h
    M llvm/unittests/ADT/IteratorTest.cpp

  Log Message:
  -----------
  [llvm] Remove uses of deprecated `std::iterator`

std::iterator has been deprecated in C++17 and some standard library implementations such as MS STL or libc++ emit deperecation messages when using the class.
Since LLVM has now switched to C++17 these will emit warnings on these implementations, or worse, errors in build configurations using -Werror.

This patch fixes these issues by replacing them with LLVMs own llvm::iterator_facade_base which offers a superset of functionality of std::iterator.

Differential Revision: https://reviews.llvm.org/D131320


Compare: https://github.com/llvm/llvm-project/compare/c59c8a515f54...f7b73b7e8e67


More information about the All-commits mailing list