[all-commits] [llvm/llvm-project] 0948f1: Reapply the commits to enable accurate hit-count d...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0948f1cf8177e378bdea2239b8c3ffb9db31f9ad
      https://github.com/llvm/llvm-project/commit/0948f1cf8177e378bdea2239b8c3ffb9db31f9ad
  Author: Jim Ingham <jingham at apple.com>
  Date:   2022-08-05 (Fri, 05 Aug 2022)

  Changed paths:
    M lldb/include/lldb/Breakpoint/Watchpoint.h
    M lldb/include/lldb/Target/StopInfo.h
    M lldb/include/lldb/Target/Thread.h
    M lldb/include/lldb/Target/ThreadPlan.h
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Target/StopInfo.cpp
    M lldb/source/Target/Thread.cpp
    M lldb/source/Target/ThreadList.cpp
    M lldb/test/API/commands/watchpoints/watchpoint_commands/condition/TestWatchpointConditionCmd.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentDelayWatchBreak.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentManyWatchpoints.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentNWatchNBreak.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentSignalNWatchNBreak.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentSignalWatch.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentSignalWatchBreak.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointThreads.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneBreakpoint.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneDelayBreakpoint.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneSignal.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentWatchBreak.py

  Log Message:
  -----------
  Reapply the commits to enable accurate hit-count detection for watchpoints.

This commit combines the initial commit (7c240de609af), a fix for x86_64 Linux
(3a0581501e76) and a fix for thinko in a last minute rewrite that I really
should have run the testsuite on.

Also, make sure that all the "I need to step over watchpoint" plans execute
before we call a public stop.  Otherwise, e.g. if you have N watchpoints and
a Signal, the signal stop info will get us to stop with the watchpoints in a
half-done state.

Differential Revision: https://reviews.llvm.org/D130674