[all-commits] [llvm/llvm-project] 71ebcd: [lldb] Make LLDB resilient against failing dyld in...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 71ebcd3348061de2fde3a13f1adb56059aca5997
      https://github.com/llvm/llvm-project/commit/71ebcd3348061de2fde3a13f1adb56059aca5997
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2022-08-03 (Wed, 03 Aug 2022)

  Changed paths:
    M lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm

  Log Message:
  -----------
  [lldb] Make LLDB resilient against failing dyld introspection SPIs

Make LLDB resilient against failing dyld introspection SPIs:

 - dyld_process_create_for_current_task
 - dyld_process_snapshot_create_for_process
 - dyld_process_snapshot_get_shared_cache

These can all fail and return a nullptr. Instead of having an assert,
which doesn't really make sense, as we have no control over whether
these calls succeed or not, bail out gracefully and use the fallback
logic.

rdar://98070414

Differential revision: https://reviews.llvm.org/D131110