[all-commits] [llvm/llvm-project] d3c460: [GIsel] Add missing space between type and name in...

Kai Nacke via All-commits all-commits at lists.llvm.org
Tue Aug 2 10:36:32 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d3c4609855e161a8f7a845b42e685ce8273af09c
      https://github.com/llvm/llvm-project/commit/d3c4609855e161a8f7a845b42e685ce8273af09c
  Author: Kai Nacke <kai.nacke at de.ibm.com>
  Date:   2022-08-02 (Tue, 02 Aug 2022)

  Changed paths:
    M llvm/utils/TableGen/GICombinerEmitter.cpp

  Log Message:
  -----------
  [GIsel] Add missing space between type and name in GICombinerHelperArg

When using AdditionalArguments in a GICombinerHelper, the generator
does not put a space between the type and the name.

E.g.

let AdditionalArguments = [GICombinerHelperArg<"bool", "IsSomething">];

ends up as

boolIsSomething) const;

in the generated file. This change adds a space between the type and the name.

Reviewed By: aemerson

Differential Revision: https://reviews.llvm.org/D130823


  Commit: b38375378dea604b8957f35d6c8a128c63c971d9
      https://github.com/llvm/llvm-project/commit/b38375378dea604b8957f35d6c8a128c63c971d9
  Author: Kai Nacke <kai.nacke at de.ibm.com>
  Date:   2022-08-02 (Tue, 02 Aug 2022)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
    M llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp

  Log Message:
  -----------
  [GIsel] Add missing libcall for G_MUL to LegalizerHelper

The LegalizerHelper misses the code to lower G_MUL to a library call,
which this change adds.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D130987


Compare: https://github.com/llvm/llvm-project/compare/71aecbb75c7d...b38375378dea


More information about the All-commits mailing list