[all-commits] [llvm/llvm-project] b50177: [JITLink][COFF] Handle COMDAT symbol with offset.

Sunho Kim via All-commits all-commits at lists.llvm.org
Sat Jul 30 17:10:04 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b501770aef85008089ceff708e1471c3eeec1f3a
      https://github.com/llvm/llvm-project/commit/b501770aef85008089ceff708e1471c3eeec1f3a
  Author: Sunho Kim <ksunhokim123 at gmail.com>
  Date:   2022-07-31 (Sun, 31 Jul 2022)

  Changed paths:
    M llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp
    M llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.h
    M llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_any.test
    M llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_exact_match.test
    M llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_intervene.test
    M llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_largest.test
    M llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_noduplicate.test
    A llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_offset.test
    M llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_same_size.test
    M llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_weak.s

  Log Message:
  -----------
  [JITLink][COFF] Handle COMDAT symbol with offset.

Handles COMDAT symbol with an offset and refactor the code to only generated symbol if the second symbol was encountered. This happens very infrequently but happens in recursive_mutex implementation of MSVC STL library.

Reviewed By: lhames

Differential Revision: https://reviews.llvm.org/D130454




More information about the All-commits mailing list