[all-commits] [llvm/llvm-project] 468d4f: Revert "[BOLT] Ignore functions accessing false po...

Amir Ayupov via All-commits all-commits at lists.llvm.org
Sat Jul 30 10:40:03 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 468d4f6d188d58c07f531279e2bce2f7c13093ab
  Author: Amir Ayupov <aaupov at fb.com>
  Date:   2022-07-30 (Sat, 30 Jul 2022)

  Changed paths:
    M bolt/lib/Core/BinaryContext.cpp
    R bolt/test/X86/fake_jump_table.s

  Log Message:
  Revert "[BOLT] Ignore functions accessing false positive jump tables"

This diff uncovers an ASAN leak in getOrCreateJumpTable:
Indirect leak of 264 byte(s) in 1 object(s) allocated from:
    #1 0x4f6e48c in llvm::bolt::BinaryContext::getOrCreateJumpTable ...
The removal of an assertion needs to be accompanied by proper deallocation of
a `JumpTable` object for which `analyzeJumpTable` was unsuccessful.

This reverts commit 52cd00cabf479aa7eb6dbb063b7ba41ea57bce9e.

More information about the All-commits mailing list