[all-commits] [llvm/llvm-project] af3ed4: [mlir] Introduce DefaultValuedOptionalAttr

Jacques Pienaar via All-commits all-commits at lists.llvm.org
Thu Jul 28 14:43:28 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: af3ed4a2a760580e9f0e04c7320edafc575d02b8
      https://github.com/llvm/llvm-project/commit/af3ed4a2a760580e9f0e04c7320edafc575d02b8
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2022-07-28 (Thu, 28 Jul 2022)

  Changed paths:
    M mlir/include/mlir/IR/OpBase.td
    M mlir/test/mlir-tblgen/op-attribute.td

  Log Message:
  -----------
  [mlir] Introduce DefaultValuedOptionalAttr

Currently DefaultValuedAttr is confusingly actually default valued &
optional but that was an artifact of development and longstanding TODO
to address. Add new attribute that matches this behavior for cases where
that is actually the desired behavior before addressing TODO (e.g., this
is an incremental step to fixing DefaultValuedAttr).

Differential Revision: https://reviews.llvm.org/D130679




More information about the All-commits mailing list